Fix handling of binary output with output format override #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbardino
added this to the
Python3 support for general research data sites milestone
jonasbardino
force-pushed
the
fix/handling-of-binary-output-with-output-format-override
branch
from
096bf6d to
be248e9
Compare
`output_format` in the functionality backends. Reuses the `delay_format` idea only available in CGI, but generalizes it to use the `start` output_object entry, which is trivially available both in CGI and WSGI. Includes preparations for refactoring into a shared helper to refresh output format but a few differences between CGI and WSGI handling still prevent that step. Synchronizes CGI `output_format` parsing with that in WSGI to use first instead of last entry; probably never an issue but better safe than sorry.
…in cgi and wsgi core. Introduces the new `mig/lib/` subdir with a simple `xgicore.py` module in it. It only contains a few new helper functions refactored from the Xgi cores and it is clean, linted and unit tested in line with what we previously agreed on in the dev team. Further modules can be added or migrated there as we proceed with the brush-up of old code.
…e new `mig/lib/xgicore.py` and sorted the corresponding new imports as suggested by _isort_. Polished `mig/lib/README` a bit.
jonasbardino
force-pushed
the
fix/handling-of-binary-output-with-output-format-override
branch
from
158fc82 to
6362ea3
Compare
jonasbardino
deleted the
fix/handling-of-binary-output-with-output-format-override
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust
cgiscriptstubandmigwsgito allow consistent overriding ofoutput_formatin the functionality backends.Reuses the
delay_formatidea only available in CGI, but generalizes it to use thestartoutput_object entry, which is trivially available both in CGI and WSGI.Includes refactoring of previously duplicated cgi and wsgi code for
output_formatparsing andstartentry init plus header mangling into a sharedxgicorehelper in the newmig/libsubdir. Please refer to the included README there for details.Synchronizes CGI
output_formatparsing with that in WSGI to use first instead of last entry; probably never an issue but better safe than sorry.